[ 
https://issues.apache.org/jira/browse/HADOOP-14771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151242#comment-16151242
 ] 

Sean Busbey edited comment on HADOOP-14771 at 9/1/17 10:27 PM:
---------------------------------------------------------------

{quote}
HADOOP-14238 mentions that Guava is exposed in an AMRMClient API. I assume this 
matters if we shade yarn-client?

We probably do need to do a sweep of the public APIs for additional third-party 
library exposure.
{quote}

It matters. I'll see if there's a tool we can use to automate checking for 
these things. A first-pass approach can be to just keep the shaded version of 
the library as the thing that's in the API (though this is obviously less than 
optimal).

Since this was a thing called out early in the shading discussion (I think 
maybe by Steve L?) I assume this is a larger concern than just yarn-client and 
thus shouldn't hold up this change. If no one disagrees with that, I'll make a 
new subtask to figure out our exposure.


was (Author: busbey):
> HADOOP-14238 mentions that Guava is exposed in an AMRMClient API. I assume 
> this matters if we shade yarn-client?
> We probably do need to do a sweep of the public APIs for additional 
> third-party library exposure.

It matters. I'll see if there's a tool we can use to automate checking for 
these things. A first-pass approach can be to just keep the shaded version of 
the library as the thing that's in the API (though this is obviously less than 
optimal).

Since this was a thing called out early in the shading discussion (I think 
maybe by Steve L?) I assume this is a larger concern than just yarn-client and 
thus shouldn't hold up this change. If no one disagrees with that, I'll make a 
new subtask to figure out our exposure.

> hadoop-client does not include hadoop-yarn-client
> -------------------------------------------------
>
>                 Key: HADOOP-14771
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14771
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: common
>            Reporter: Haibo Chen
>            Assignee: Ajay Kumar
>            Priority: Blocker
>         Attachments: HADOOP-14771.01.patch
>
>
> The hadoop-client does not include hadoop-yarn-client, thus, the shared 
> hadoop-client is incomplete. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to