[
https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824873#comment-16824873
]
Chao Sun commented on HADOOP-16266:
-----------------------------------
Thanks [~cgregori]. A few comments on patch v2:
- I see that with the patch, {{RpcScheduler#addResponseTime(String, int, int,
int)}} is no longer used anywhere. Curious what are the risks by removing it?
- With the default implementation in {{RpcScheduler}}, you should not need to
provide another impl in {{DefaultRpcScheduler}}.
- Unused import in {{TestConsistentReadsObserver}}.
- Still thinking whether the default time unit for {{ProcessingDetails}} can
be nano instead micro. At the moment we are passing nano through
{{ProcessingDetails#set()}} and then convert to micro, which seems unnecessary.
- Some indentation is off such as {{DecayedRpcScheduler#addResponseTime}}.
- Maybe it's worth pointing out that processing time always equal to
{{lock_free + lock_wait + lock_shared + lock_exclusive)}} in
{{ProcessingDetails}}?
- We'll need to add documentation for the newly added metrics
[here|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/site/markdown/Metrics.md].
> Add more fine-grained processing time metrics to the RPC layer
> --------------------------------------------------------------
>
> Key: HADOOP-16266
> URL: https://issues.apache.org/jira/browse/HADOOP-16266
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Christopher Gregorian
> Assignee: Christopher Gregorian
> Priority: Minor
> Labels: rpc
> Attachments: HADOOP-16266.001.patch, HADOOP-16266.002.patch
>
>
> Splitting off of HDFS-14403 to track the first part: introduces more
> fine-grained measuring of how a call's processing time is split up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
