[
https://issues.apache.org/jira/browse/HADOOP-16266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829793#comment-16829793
]
Erik Krogen commented on HADOOP-16266:
--------------------------------------
[~cgregori] is on vacation so I'm taking over for the time being. I put up a
v007 patch that cleans up a few more checkstyle issues, and adds a {{default}}
implementation of the old {{RpcScheduler.addResponseTime()}} method to make it
more obvious that it should no longer be used. I also added a more in-depth
test within {{TestRPC}} to confirm that the new metric, {{RpcLockWaitTime}}, is
being incremented as expected. This confirms that the {{ProcessingDetails}} are
being used properly.
[[email protected]], thanks for the response. I checked and I don't think
there's anywhere here which would have issues if a negative number were
returned. I still updated {{ProcessingDetails}} to always return a nonnegative
number, even if someone puts a negative number into it, so that accessors
always see a nonegative duration.
> Add more fine-grained processing time metrics to the RPC layer
> --------------------------------------------------------------
>
> Key: HADOOP-16266
> URL: https://issues.apache.org/jira/browse/HADOOP-16266
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Christopher Gregorian
> Assignee: Christopher Gregorian
> Priority: Minor
> Labels: rpc
> Attachments: HADOOP-16266.001.patch, HADOOP-16266.002.patch,
> HADOOP-16266.003.patch, HADOOP-16266.004.patch, HADOOP-16266.005.patch,
> HADOOP-16266.006.patch, HADOOP-16266.007.patch
>
>
> Splitting off of HDFS-14403 to track the first part: introduces more
> fine-grained measuring of how a call's processing time is split up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
