[
https://issues.apache.org/jira/browse/HADOOP-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063684#comment-13063684
]
Uma Maheswara Rao G commented on HADOOP-7455:
---------------------------------------------
Hi Suresh,
Small comment
{code}
+ /**
+ * Promote a service in standby state to active state. No operation, if the
+ * service is already in active state.
+ *
+ * @throws ServiceException
+ * if promoting the service state to active fails.
+ */
+ public void promote() throws ServiceException;
{code}
Just by seeing this api name we may not be able to understand what this API
will do. We must read the javadoc.
I feel by seeing the API itself some minimum idea we should get. Can it be more
explanative?
for example: standByToActive() , because API doc directly explainig the same.
One more point,
What if the HA coordination system network is not reachable? For example if i
use Zookeeper for switching the states. If Zookeeper network is not reachable
then NN processes should go into which state.? In this sistuation, I feel we
can have one api which will move the process state to Ideal (or) Neutral to
avoid splitbrains.
> Introduce HA Service Protocol Interface
> ---------------------------------------
>
> Key: HADOOP-7455
> URL: https://issues.apache.org/jira/browse/HADOOP-7455
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: util
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7455.1.patch, HDFS-7454.patch
>
>
> This jira introduces a protocol interface to be implemented by services that
> provide HA functionality.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira