[
https://issues.apache.org/jira/browse/HADOOP-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113785#comment-13113785
]
Jitendra Nath Pandey commented on HADOOP-7510:
----------------------------------------------
This jira is about setting hostname in token service. Shouldn't the ports in
HftpFileSystem remain unchanged as far as this patch is concerned. Please file
a different jira to fix "wrong" ports.
> Your change in HADOOP-7661 undid the agreed upon change in HADOOP-7602. I
> simply changed it back.
Unfortunately, HADOOP-7602 fix was incomplete. It fixed only HarFileSystem.
But it was discovered that problem was more general and HADOOP-7602 didn't fix
NPE for other file systems.
HADOOP-7661 fixed it for all file systems that didn't have valid authority. I
think returning null for all file systems except Hdfs and Hftp is not a good
idea. This api is used in only TokenCache in hadoop, but it is a public API
(unfortunately).
> If you are concerned about changing a public api, I'm not sure why completely
> changing the semantics of
> getCanonicalServiceName is not a cause for concern.
Before HADOOP-7661, javadoc for this method said "@return a URI string that
uniquely identifies this file system". That way returning URI by default is not
really a big change and is not an "abuse". In fact, now I am convinced that
HarFileSystem should also be changed back to return URI instead of null, but
that should be addressed in a different jira.
> Tokens should use original hostname provided instead of ip
> ----------------------------------------------------------
>
> Key: HADOOP-7510
> URL: https://issues.apache.org/jira/browse/HADOOP-7510
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.20.205.0
>
> Attachments: HADOOP-7510-10.patch, HADOOP-7510-2.patch,
> HADOOP-7510-3.patch, HADOOP-7510-4.patch, HADOOP-7510-5.patch,
> HADOOP-7510-6.patch, HADOOP-7510-8.patch, HADOOP-7510-9.patch,
> HADOOP-7510.patch
>
>
> Tokens currently store the ip:port of the remote server. This precludes
> tokens from being used after a host's ip is changed. Tokens should store the
> hostname used to make the RPC connection. This will enable new processes to
> use their existing tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
