[
https://issues.apache.org/jira/browse/HADOOP-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113794#comment-13113794
]
Daryn Sharp commented on HADOOP-7510:
-------------------------------------
bq. This jira is about setting hostname in token service. Shouldn't the ports
in HftpFileSystem remain unchanged as far as this patch is concerned. Please
file a different jira to fix "wrong" ports.
This change been in the patch for quite sometime, and it was not an objection
as of 9/16. Why is this now an issue?
bq. But it was discovered that problem was more general and HADOOP-7602 didn't
fix NPE for other file systems.
Please re-examine the changes in this patch. I have already fixed the root
issue involving the NPE, as per our discussions during HADOOP-7602.
bq. I think returning null for all file systems except Hdfs and Hftp is not a
good idea.
Please re-examine the code and re-read my previous comment. That's not what
it's doing.
bq. Before HADOOP-7661, javadoc for this method said "@return a URI string that
uniquely identifies this file system".
Unfortunately, the documentation was wrong. Without my patch, the
{{TokenCache}} uses this method to stomp on the service in a token. That's not
going to work. Given the prior concern over changing it all, I'm honestly
shocked that you want to completely change its semantics.
{{getCanonicalServiceName}} is for getting a token's service. {{getUri()}} is
for getting the uri. As much as I may have wanted service to be a uri, that
was nixed during the renewal changes.
bq. In fact, now I am convinced that HarFileSystem should also be changed back
to return URI instead of null.
What benefit would that provide?
> Tokens should use original hostname provided instead of ip
> ----------------------------------------------------------
>
> Key: HADOOP-7510
> URL: https://issues.apache.org/jira/browse/HADOOP-7510
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.20.205.0
>
> Attachments: HADOOP-7510-10.patch, HADOOP-7510-2.patch,
> HADOOP-7510-3.patch, HADOOP-7510-4.patch, HADOOP-7510-5.patch,
> HADOOP-7510-6.patch, HADOOP-7510-8.patch, HADOOP-7510-9.patch,
> HADOOP-7510.patch
>
>
> Tokens currently store the ip:port of the remote server. This precludes
> tokens from being used after a host's ip is changed. Tokens should store the
> hostname used to make the RPC connection. This will enable new processes to
> use their existing tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
