[
https://issues.apache.org/jira/browse/HADOOP-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114412#comment-13114412
]
Suresh Srinivas commented on HADOOP-7510:
-----------------------------------------
Jitendra, I will take a look at the patch. Here are some preliminary comments.
There was lot of comments in this and related jiras, that required lot of time
to catchup.
# NetUtils.java
#* throwIllegalAuthorityArgument - A separate method just for throwing
exception is unnecessary. Could you please just throw the exception instead of
calling a method?
#* Why is createSocketAddr() change needed in *this* patch? If it is really
needed -
#** Instead of "host://" please use "dummyscheme://"
#** createSocketAddr - Method looks much better now. But why should is it
calling makeSocketAddr(). This method does not have any requirement that
makeSocketAddr() is trying to address right?
#* Please add class javadoc to HostResolver
#* Please make setHostResolver package private static instead protected static.
protected static does not make sense and what you need is package private for
test access. This holds good for SecurityUtil#setTokenServiceUseIp()
#* HostResolver#getInetAddressByName() seems unnecessary. You can just use
InetAddress.getByName()
#* HostResolver#getByName() javadoc mentions getCanonicalHostName(), not sure
what that is. If it is FileSystem#getCanonicalServiceName(), there is no need
to reference FileSystem into NetUtils.
# It may be a good idea to move HostResolver, that uses sun specific libraries
to separate file.
# HftpFileSystem.java - indentation of some of the methods is off (due to tab).
Will post the comments based on reviewing the rest of the patch soon.
> Tokens should use original hostname provided instead of ip
> ----------------------------------------------------------
>
> Key: HADOOP-7510
> URL: https://issues.apache.org/jira/browse/HADOOP-7510
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.20.205.0
>
> Attachments: HADOOP-7510-10.patch, HADOOP-7510-2.patch,
> HADOOP-7510-3.patch, HADOOP-7510-4.patch, HADOOP-7510-5.patch,
> HADOOP-7510-6.patch, HADOOP-7510-8.patch, HADOOP-7510-9.patch,
> HADOOP-7510.patch
>
>
> Tokens currently store the ip:port of the remote server. This precludes
> tokens from being used after a host's ip is changed. Tokens should store the
> hostname used to make the RPC connection. This will enable new processes to
> use their existing tokens.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
