[ 
https://issues.apache.org/jira/browse/HADOOP-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115107#comment-13115107
 ] 

Suresh Srinivas commented on HADOOP-7510:
-----------------------------------------

Daryn, I have some minor comments:
# The following is disabled also because, the hostResolver functionality is 
needed only use_ip is enabled, even if it is safe. You could make a case 
otherwise. Until then there is no need for comment below.
{noformat}
+  // although this setting isn't strictly related to this class, it will
+  // short out the custom host resolution until it can be proven to be safe

+   * NOTE: although this resolver is of general utility, it is only used
+   *       if hadoop.security.token.service.use_ip=false 
{noformat}
# Please remove "Intended only for temporary use by NetUtils.  Do not use.". 
You are just providing access to the config item, where this comment is not 
necessary.

                
> Tokens should use original hostname provided instead of ip
> ----------------------------------------------------------
>
>                 Key: HADOOP-7510
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7510
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.20.205.0
>
>         Attachments: HADOOP-7510-10.patch, HADOOP-7510-11.patch, 
> HADOOP-7510-2.patch, HADOOP-7510-3.patch, HADOOP-7510-4.patch, 
> HADOOP-7510-5.patch, HADOOP-7510-6.patch, HADOOP-7510-8.patch, 
> HADOOP-7510-9.patch, HADOOP-7510.patch
>
>
> Tokens currently store the ip:port of the remote server.  This precludes 
> tokens from being used after a host's ip is changed.  Tokens should store the 
> hostname used to make the RPC connection.  This will enable new processes to 
> use their existing tokens.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to