[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773350
]
ASF GitHub Bot logged work on HADOOP-18248:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 08:39
Start Date: 23/May/22 08:39
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879160238
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##########
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
- assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original indentation.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##########
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
- assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original indentation.
Issue Time Tracking
-------------------
Worklog Id: (was: 773350)
Time Spent: 1h 40m (was: 1.5h)
> Fix Junit Test Deprecated assertThat
> ------------------------------------
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
