[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773446
]
ASF GitHub Bot logged work on HADOOP-18248:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 12:02
Start Date: 23/May/22 12:02
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879374438
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##########
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
- assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Thank you, I will fix it.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java:
##########
@@ -82,8 +82,13 @@
import static org.apache.hadoop.hdfs.server.namenode.AclTestHelpers.aclEntry;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.not;
-import static org.junit.Assert.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
Review Comment:
OK, I will fix it.
Issue Time Tracking
-------------------
Worklog Id: (was: 773446)
Time Spent: 2h 10m (was: 2h)
> Fix Junit Test Deprecated assertThat
> ------------------------------------
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> <T>assertThat(T,Matcher<? super T>) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
