[
https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=794640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794640
]
ASF GitHub Bot logged work on HADOOP-18357:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/22 17:16
Start Date: 24/Jul/22 17:16
Worklog Time Spent: 10m
Work Description: goiri commented on code in PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#discussion_r928287817
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj.filters:
##########
@@ -48,19 +46,16 @@
<ClCompile Include="src\org\apache\hadoop\util\NativeCodeLoader.c">
<Filter>Source Files</Filter>
</ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\compress\lz4\lz4.c">
- <Filter>Source Files</Filter>
- </ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\compress\lz4\lz4hc.c">
+ <ClCompile
Include="src\org\apache\hadoop\security\JniBasedUnixGroupsMappingWin.c">
<Filter>Source Files</Filter>
</ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\compress\lz4\Lz4Compressor.c">
+ <ClCompile
Include="src\org\apache\hadoop\io\compress\zlib\ZlibCompressor.c">
Review Comment:
Why are we changing this?
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -39,12 +37,14 @@
<UseDebugLibraries>false</UseDebugLibraries>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review Comment:
What was the old number and where was it defined?
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -142,16 +140,16 @@
<ClCompile Include="src\org\apache\hadoop\io\erasurecode\isal_load.c"
Condition="'$(IsalEnabled)' == 'true'">
<AdditionalOptions>/D
HADOOP_ISAL_LIBRARY=L\"isa-l.dll\"</AdditionalOptions>
</ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\erasure_code.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\gf_util.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\erasure_coder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\dump.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile
Include="src\org\apache\hadoop\io\erasurecode\jni_erasure_code_native.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\jni_common.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\jni_rs_encoder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile Include="src\org\apache\hadoop\io\erasurecode\jni_rs_decoder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile
Include="src\org\apache\hadoop\io\erasurecode\jni_xor_encoder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
- <ClCompile
Include="src\org\apache\hadoop\io\erasurecode\jni_xor_decoder.c"
Condition="'$(IsalEnabled)' == 'true'"/>
+ <ClCompile Include="src\org\apache\hadoop\io\erasurecode\erasure_code.c"
Condition="'$(IsalEnabled)' == 'true'" />
Review Comment:
Can we avoid these changes?
Issue Time Tracking
-------------------
Worklog Id: (was: 794640)
Time Spent: 20m (was: 10m)
> Retarget solution file to VS2019
> --------------------------------
>
> Key: HADOOP-18357
> URL: https://issues.apache.org/jira/browse/HADOOP-18357
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: libhdfscpp, pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Visual Studio version used by winutils and native components in Hadoop
> common are quite old. We need to retarget the solution and vcxproj files to
> use the latest version (Visual Studio 2019 as of this writing).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
