[
https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795386
]
ASF GitHub Bot logged work on HADOOP-18357:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/22 18:30
Start Date: 26/Jul/22 18:30
Worklog Time Spent: 10m
Work Description: GauthamBanasandra commented on code in PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#discussion_r930293301
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -39,12 +37,14 @@
<UseDebugLibraries>false</UseDebugLibraries>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review Comment:
I ran the retarget command from `VS2019 command prompt`, thus the retarget
tool added the PlatformToolset version corresponding to VS2019.
The retarget command would take care of inserting the right version based on
Visual Studio command prompt that we choose. Please also note that the
subsequent `mvn install` command must be run from the same command prompt.
Issue Time Tracking
-------------------
Worklog Id: (was: 795386)
Time Spent: 1h 40m (was: 1.5h)
> Retarget solution file to VS2019
> --------------------------------
>
> Key: HADOOP-18357
> URL: https://issues.apache.org/jira/browse/HADOOP-18357
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: libhdfscpp, pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The Visual Studio version used by winutils and native components in Hadoop
> common are quite old. We need to retarget the solution and vcxproj files to
> use the latest version (Visual Studio 2019 as of this writing).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
