[
https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795629
]
ASF GitHub Bot logged work on HADOOP-18357:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/22 12:15
Start Date: 27/Jul/22 12:15
Worklog Time Spent: 10m
Work Description: GauthamBanasandra commented on code in PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#discussion_r930987990
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj:
##########
@@ -39,12 +37,14 @@
<UseDebugLibraries>false</UseDebugLibraries>
<WholeProgramOptimization>true</WholeProgramOptimization>
<CharacterSet>Unicode</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review Comment:
> why would we add it now?
The compilation fails without the `PlatformToolset` when compiled with
Visual Studio 2019 (I'm not sure about VS2010). I'm fine with documenting
running the retarget command as a pre-requisite step prior to running the `mvn
install` command, if we don't want to add the `PlatformToolset` here.
Issue Time Tracking
-------------------
Worklog Id: (was: 795629)
Time Spent: 2h 10m (was: 2h)
> Retarget solution file to VS2019
> --------------------------------
>
> Key: HADOOP-18357
> URL: https://issues.apache.org/jira/browse/HADOOP-18357
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: libhdfscpp, pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The Visual Studio version used by winutils and native components in Hadoop
> common are quite old. We need to retarget the solution and vcxproj files to
> use the latest version (Visual Studio 2019 as of this writing).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
