[
https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=794988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794988
]
ASF GitHub Bot logged work on HADOOP-18357:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/22 17:24
Start Date: 25/Jul/22 17:24
Worklog Time Spent: 10m
Work Description: GauthamBanasandra commented on code in PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#discussion_r929126701
##########
hadoop-common-project/hadoop-common/src/main/native/native.vcxproj.filters:
##########
@@ -48,19 +46,16 @@
<ClCompile Include="src\org\apache\hadoop\util\NativeCodeLoader.c">
<Filter>Source Files</Filter>
</ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\compress\lz4\lz4.c">
- <Filter>Source Files</Filter>
- </ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\compress\lz4\lz4hc.c">
+ <ClCompile
Include="src\org\apache\hadoop\security\JniBasedUnixGroupsMappingWin.c">
<Filter>Source Files</Filter>
</ClCompile>
- <ClCompile Include="src\org\apache\hadoop\io\compress\lz4\Lz4Compressor.c">
+ <ClCompile
Include="src\org\apache\hadoop\io\compress\zlib\ZlibCompressor.c">
Review Comment:
These changes were automatically made by Visual Studio when I ran the
retarget command.
The `lz4` library was removed in https://github.com/apache/hadoop/pull/2576.
The author didn't remove them from Visual Studio, so I removed them -
https://github.com/apache/hadoop/commit/44910b53f383f8ab092b7f9889fbf353e057d3f7.
But I forgot to remove them from `native.vcxproj.filters` file (the current
file). When I retargeted the native project, Visual Studio was smart enough to
detect that these files don't exist and has removed them for us.
Issue Time Tracking
-------------------
Worklog Id: (was: 794988)
Time Spent: 1h (was: 50m)
> Retarget solution file to VS2019
> --------------------------------
>
> Key: HADOOP-18357
> URL: https://issues.apache.org/jira/browse/HADOOP-18357
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: libhdfscpp, pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The Visual Studio version used by winutils and native components in Hadoop
> common are quite old. We need to retarget the solution and vcxproj files to
> use the latest version (Visual Studio 2019 as of this writing).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
