[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696303#comment-17696303
]
ASF GitHub Bot commented on HADOOP-18631:
-----------------------------------------
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1454074972
> The path was unique earlier
>
> ```
> static final String AUDITLOG_FILE =
> GenericTestUtils.getTempPath("TestFsck-audit.log");
> ```
That's because the previous version was using dynamically added appenders
and disregarding the actual appenders set in log4j properties, this was a hack
and it would not work with log4j2. Hence we changed that with previous PR. Now
the tests share the same file location for the audit log, because it's the
log4j properties that all tests share.
We can make a new custom log4j properties and reload it dynamically, that's
an option but again it would be another hack because in log4j2, while this is
allowed, the APIs are not public and can break compatibilities.
> Migrate Async appenders to log4j properties
> -------------------------------------------
>
> Key: HADOOP-18631
> URL: https://issues.apache.org/jira/browse/HADOOP-18631
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Before we can upgrade to log4j2, we need to migrate async appenders that we
> add "dynamically in the code" to the log4j.properties file. Instead of using
> core/hdfs site configs, log4j properties or system properties should be used
> to determine if the given logger should use async appender.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
