[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696305#comment-17696305
]
ASF GitHub Bot commented on HADOOP-18631:
-----------------------------------------
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1454082092
Here is the most imp distinguisher for tests before and after PR #5418 :
Before patch: The tests were deciding which log file to use and also
disabling async appender soon after the expected logs were in. Hence, the tests
can match the expected regex. This is hack because overriding log4j properties
is not compatible across log4j versions.
After patch: The tests share the same log file for audit log and no longer
applies hack of changing the log file dynamically and stopping appenders when
needed etc. Hence, now the tests are made to search for regex only for
"specific file operations" because audit logs will have operations for other
tests as well. We no longer have any hacks here that log4j2 does not support
(or recommend doing).
> Migrate Async appenders to log4j properties
> -------------------------------------------
>
> Key: HADOOP-18631
> URL: https://issues.apache.org/jira/browse/HADOOP-18631
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Before we can upgrade to log4j2, we need to migrate async appenders that we
> add "dynamically in the code" to the log4j.properties file. Instead of using
> core/hdfs site configs, log4j properties or system properties should be used
> to determine if the given logger should use async appender.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
