[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696310#comment-17696310
]
ASF GitHub Bot commented on HADOOP-18631:
-----------------------------------------
ayushtkn commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1454095017
> Do not delete file in TestFsck because it's already used by other tests
(this should anyways be followed even though we go with other solutions)
&
> Moving the test to other module so it can use different log4j properties
(not preferred)
I am against this. First one is being too much confident, that tests won't
collide and today we know they aren't. tommorow if suddenly they do, other
folks who doesn't know about it would be struggling to figure this out. We
don't want to leave the code in a worse state than we have today.
Second one I already have said the reason above
> Have a new custom log4j properties and hack loading it dynamically for
TestFsck (some yarn test does this hack as of today)
If they are doing only, then we have a solution ready only, lets do it or
pull that into a util and use it everywhere. I don't have hard feeling about
other options(as of now), but this one sounds best to me
> Migrate Async appenders to log4j properties
> -------------------------------------------
>
> Key: HADOOP-18631
> URL: https://issues.apache.org/jira/browse/HADOOP-18631
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Before we can upgrade to log4j2, we need to migrate async appenders that we
> add "dynamically in the code" to the log4j.properties file. Instead of using
> core/hdfs site configs, log4j properties or system properties should be used
> to determine if the given logger should use async appender.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
