[
https://issues.apache.org/jira/browse/HADOOP-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696342#comment-17696342
]
ASF GitHub Bot commented on HADOOP-18631:
-----------------------------------------
virajjasani commented on PR #5451:
URL: https://github.com/apache/hadoop/pull/5451#issuecomment-1454160995
Also, FWIW, in this particular revision, I also removed the file delete
operation from TestAuditLogs too because deleting the file is no longer needed
as all tests share the same file.
https://github.com/apache/hadoop/pull/5418/commits/bace0390b7e9f224232f943e7f40da08bbbe5f37
What we can do to ensure avoiding collision is keep all audit log specific
tests to one test file only, for instance TestAuditLogs. It would ensure file
is cleaned up before starting the test and it will do it's own duty to check
and verify if all necessary regex patterns are matching.
TestFsck has only 3 tests that need to validate regex of audit logs, so we
can move them to TestAuditLogs and check for fsck specific audit log regex too.
> Migrate Async appenders to log4j properties
> -------------------------------------------
>
> Key: HADOOP-18631
> URL: https://issues.apache.org/jira/browse/HADOOP-18631
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Before we can upgrade to log4j2, we need to migrate async appenders that we
> add "dynamically in the code" to the log4j.properties file. Instead of using
> core/hdfs site configs, log4j properties or system properties should be used
> to determine if the given logger should use async appender.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
