[
https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787188#comment-17787188
]
ASF GitHub Bot commented on HADOOP-18957:
-----------------------------------------
pjfanning commented on code in PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397275697
##########
pom.xml:
##########
@@ -225,6 +225,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/x
<bannedImport>org.apache.hadoop.thirdparty.com.google.common.io.BaseEncoding.**</bannedImport>
</bannedImports>
</restrictImports>
+ <restrictImports>
+ <includeTestCode>true</includeTestCode>
+ <reason>Use java.nio.charset.StandardCharsets rather than
Guava provided Charsets</reason>
Review Comment:
Yes - we still need java.nio.charset.Charset. The StandardCharsets are
implementations of the Charset interface and there are cases where we need to
call Charset.forName when the charset is not hardcoded to UTF-8.
> Use StandardCharsets.UTF_8 constant
> -----------------------------------
>
> Key: HADOOP-18957
> URL: https://issues.apache.org/jira/browse/HADOOP-18957
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> * there are some places in the code that have to check for
> UnsupportedCharsetException when explicitly using the charset name "UTF-8"
> * using StandardCharsets.UTF_8 is more efficient because the Java libs
> usually have to look up the charsets when you provide it as String param
> instead
> * also stop using Guava Charsets and use StandardCharsets
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
