[
https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787496#comment-17787496
]
ASF GitHub Bot commented on HADOOP-18957:
-----------------------------------------
pjfanning commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1817533605
> yetus reports some checksyle warnings
@ayushtkn do you have tips and tricks for how to find checkstyle issues
caused by a PR?
This PR is pretty big touching 100s of files and there are 1000s of
pre-existing checkstyle issues.
I tried concentrating on going through LineLength and UnusedImports issues
but there are 100s of them and after spending a while on them I hadn't yet
reached one that was caused by me.
To be honest, I'm not really in a good position time wise to read through
such a large checkstyle output. I code mainly in Scala and tools like scalafmt
will not only spot checkstyle issues, it will fix them too.
> Use StandardCharsets.UTF_8 constant
> -----------------------------------
>
> Key: HADOOP-18957
> URL: https://issues.apache.org/jira/browse/HADOOP-18957
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> * there are some places in the code that have to check for
> UnsupportedCharsetException when explicitly using the charset name "UTF-8"
> * using StandardCharsets.UTF_8 is more efficient because the Java libs
> usually have to look up the charsets when you provide it as String param
> instead
> * also stop using Guava Charsets and use StandardCharsets
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
