[
https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787195#comment-17787195
]
ASF GitHub Bot commented on HADOOP-18957:
-----------------------------------------
pjfanning commented on code in PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#discussion_r1397293839
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/ServletUtils.java:
##########
@@ -24,14 +24,15 @@
import javax.servlet.http.HttpServletRequest;
import java.io.IOException;
import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
import java.util.List;
/**
* Servlet utility methods.
*/
@InterfaceAudience.Private
class ServletUtils {
- private static final Charset UTF8_CHARSET = Charset.forName("UTF-8");
+ private static final Charset UTF8_CHARSET = StandardCharsets.UTF_8;
Review Comment:
it is used in one place. Are you suggesting that I remove this and make the
code that uses this, use StandardCharsets.UTF_8 directly instead?
> Use StandardCharsets.UTF_8 constant
> -----------------------------------
>
> Key: HADOOP-18957
> URL: https://issues.apache.org/jira/browse/HADOOP-18957
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> * there are some places in the code that have to check for
> UnsupportedCharsetException when explicitly using the charset name "UTF-8"
> * using StandardCharsets.UTF_8 is more efficient because the Java libs
> usually have to look up the charsets when you provide it as String param
> instead
> * also stop using Guava Charsets and use StandardCharsets
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
