[
https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787501#comment-17787501
]
ASF GitHub Bot commented on HADOOP-18957:
-----------------------------------------
pjfanning commented on PR #6231:
URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1817543679
The list of 11 checkstyle issues are largely pre-existing issues With the
indentation issues, the highlighted lines match the surrounding lines in terms
of style. With the `charsetUTF8` variables, those var names were pre-existing
and I think it is better not to change the names.
In
https://github.com/apache/hadoop/pull/6231/commits/218321b665716aa887f83693540e4bc017ad8a50,
I have tried to fix one line length issue and tried to fix a pre-existing
indentation issue in a test.
> Use StandardCharsets.UTF_8 constant
> -----------------------------------
>
> Key: HADOOP-18957
> URL: https://issues.apache.org/jira/browse/HADOOP-18957
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: PJ Fanning
> Priority: Major
> Labels: pull-request-available
>
> * there are some places in the code that have to check for
> UnsupportedCharsetException when explicitly using the charset name "UTF-8"
> * using StandardCharsets.UTF_8 is more efficient because the Java libs
> usually have to look up the charsets when you provide it as String param
> instead
> * also stop using Guava Charsets and use StandardCharsets
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
