[
https://issues.apache.org/jira/browse/HADOOP-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055293#comment-14055293
]
Ravi Prakash commented on HADOOP-10727:
---------------------------------------
Hi Babak!
Thanks for the patch.
{code} if (escape_character == null)
escape_character = "_";{code}
please include a closing and ending brace. Or you could just use the ? :
operator ;
Also please write a comment on the regex, to help identify what it is filtering
for. I'm a +1 on the patch after those changes.
> GraphiteSink metric names should not contain "."
> ------------------------------------------------
>
> Key: HADOOP-10727
> URL: https://issues.apache.org/jira/browse/HADOOP-10727
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Babak Behzad
> Priority: Minor
> Attachments: HADOOP-10727.patch
>
>
> Sometimes the names of the metrics sent to Graphite contain "." in them (such
> as hostnames). Graphite interpret these dots as a separator for directories
> causing long directory hierarchies. It would be easier to replace them to "_"
> in order to have easier to read metric names.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
