[
https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206640#comment-14206640
]
Chris Nauroth commented on HADOOP-11293:
----------------------------------------
Thanks for sharing this patch, Yongjun. It's undeniable that this would reduce
coupling on the {{Shell}} class. Unfortunately, I also have to say -1 for the
current patch, for all of the reasons that Steve already described so well.
Steve's proposal of phasing in new APIs and marking the {{Shell}} APIs
deprecated would be more agreeable, but I also wonder if it's worth the effort.
This implies that someone will take responsibility for migrating all of the
downstream projects to the new APIs, or at least coordinating with those
projects' contributors. Until that migration completes across all ecosystem
projects, we'll still need to maintain both code paths. The benefit looks
small weighed against the level of effort, so perhaps our efforts are better
spent elsewhere. There are plenty of opportunities for other refactoring
improvements that won't impact downstream consumers.
Considering all of that, a patch implementing Steve's proposal would
effectively move me from -1 to -0 (still opposed, but with no intention to
block it if other committers are in favor).
> Factor OSType out from Shell
> ----------------------------
>
> Key: HADOOP-11293
> URL: https://issues.apache.org/jira/browse/HADOOP-11293
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
> Attachments: HADOOP-11293.001.patch
>
>
> Currently the code that detects the OS type is located in Shell.java. Code
> that need to check OS type refers to Shell, even if no other stuff of Shell
> is needed.
> I am proposing to refactor OSType out to its own class, so to make the
> OSType easier to access and the dependency cleaner.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
