[ 
https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208287#comment-14208287
 ] 

Chris Nauroth commented on HADOOP-11293:
----------------------------------------

Thanks for bringing all the feedback together, Yongjun.  I think it makes sense 
now.

bq. Optional: whether to change the current Hadoop code base to use the new API 
(I've done it in the initial patch), up to whether you all agree.

I don't think there is any problem with moving code in the Hadoop tree to the 
new API quickly.  I was mostly concerned with the impact to downstream 
projects, not code within the Hadoop tree itself.

> Factor OSType out from Shell
> ----------------------------
>
>                 Key: HADOOP-11293
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11293
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-11293.001.patch
>
>
> Currently the code that detects the OS type is located in Shell.java. Code 
> that need to check OS type refers to Shell, even if no other stuff of Shell 
> is needed. 
> I am proposing to refactor OSType out to  its own class, so to make the 
> OSType easier to access and the dependency cleaner.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to