[
https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209409#comment-14209409
]
Yongjun Zhang commented on HADOOP-11293:
----------------------------------------
HI Colin/Chris/Steve,
Thanks a lot for your feedback. I just uploaded rev 002 based on the proposal
summarized in my last comment.
While trying to maintain all public methods and members in Shell, I made the
following changes:
# Shell#OSType, it's kept because it is public. The change I made here is to
take the enum value from CurrentOS and map to Shell#OSType. The change may or
may not be needed. The benefit of having it is to ensure all enum values are
the same between Shell and CurrentOS. I wonder if there is any compatibility
concern with this change, I hope not, but if there is any, we can just make
Shell#OSType exactly the same as before. Actually the code would be less heavy
weight without this change. Not sure whether there are downstream projects
using this type, but since it was public, we'd better keep it as is.
# Shell#osType, it's kept again because it's public.
# Replaced osType in Shell with OS_TYPE in CurrentOS.
# Shell#PPC_64, I introduced IS_PPC_64 in CurrentOS too.
Many thanks for taking a look at this new rev.
> Factor OSType out from Shell
> ----------------------------
>
> Key: HADOOP-11293
> URL: https://issues.apache.org/jira/browse/HADOOP-11293
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
> Attachments: HADOOP-11293.001.patch, HADOOP-11293.002.patch
>
>
> Currently the code that detects the OS type is located in Shell.java. Code
> that need to check OS type refers to Shell, even if no other stuff of Shell
> is needed.
> I am proposing to refactor OSType out to its own class, so to make the
> OSType easier to access and the dependency cleaner.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
