[
https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209557#comment-14209557
]
Steve Loughran commented on HADOOP-11293:
-----------------------------------------
Looks Ok, one more iteration would do
# can you go back to {{.WINDOWS}} rather than {{IS_WINDOWS}}? Why: reduces the
effort to switch to the new API, all you need to do is replace Shell with
OsType.
# your IDE's been adding blank lines in the imports area. Can you stop
it/unwind that bit. Imports are one of the most common merge troublespots in
patches; it's bad enough already
thanks
> Factor OSType out from Shell
> ----------------------------
>
> Key: HADOOP-11293
> URL: https://issues.apache.org/jira/browse/HADOOP-11293
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
> Attachments: HADOOP-11293.001.patch, HADOOP-11293.002.patch
>
>
> Currently the code that detects the OS type is located in Shell.java. Code
> that need to check OS type refers to Shell, even if no other stuff of Shell
> is needed.
> I am proposing to refactor OSType out to its own class, so to make the
> OSType easier to access and the dependency cleaner.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
