[ 
https://issues.apache.org/jira/browse/HADOOP-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310427#comment-14310427
 ] 

Zhe Zhang commented on HADOOP-11542:
------------------------------------

Thanks Kai! I imagine RS will be our main codec algorithm. Please find my 
review below:
# Class names can be shorter. They are already .java classes so I don't think 
we need to put Java in the class name
# In the comment:
bq. A raw erasure decoder in RS code scheme in pure Java for test usage ...
I think we should remove "test usage". They'll be used all-around if native 
coders are not available.
# {{TestCoderBase}} and {{TestRawCoderBase}} are also added in HADOOP-11541.
# Can you explain {{errSignature}} a little more?
# {{GaloisField}} is fairly complex and will take more time to review. Is it 
exactly the same as in HDFS-RAID? If not, could you highlight the changes?

> Raw Reed-Solomon coder in pure Java
> -----------------------------------
>
>                 Key: HADOOP-11542
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11542
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: HDFS-EC
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HADOOP-11542-v1.patch, HADOOP-11542-v2.patch
>
>
> This will implement RS coder by porting existing codes in HDFS-RAID in the 
> new codec and coder framework, which could be useful in case native support 
> isn't available or convenient in some environments or platforms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to