[
https://issues.apache.org/jira/browse/HADOOP-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317331#comment-14317331
]
Zhe Zhang commented on HADOOP-11542:
------------------------------------
Thanks Kai for the rev! It looks good. +1 pending the following small changes
(all in {{GaloisField}}):
# "// qiu yu" should be removed
# "Given a Vandermonde matrix-fan de meng matrix-" need to remove extra comment
# Do we need to apply the mask before casting to byte?
{code}
y[j][k] = (byte) (y[j][k] ^ mulTable[x[i]][y[j - 1][k] &
0x000000FF]);
{code}
# In HADOOP-11566 we can also add a direct test for the added bulk methods,
since they are public anyway.
> Raw Reed-Solomon coder in pure Java
> -----------------------------------
>
> Key: HADOOP-11542
> URL: https://issues.apache.org/jira/browse/HADOOP-11542
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HDFS-EC
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-11542-v1.patch, HADOOP-11542-v2.patch,
> HADOOP-11542-v3.patch, HADOOP-11542-v4.patch, HDFS-RAID-GaloisField.java
>
>
> This will implement RS coder by porting existing codes in HDFS-RAID in the
> new codec and coder framework, which could be useful in case native support
> isn't available or convenient in some environments or platforms.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
