[
https://issues.apache.org/jira/browse/HADOOP-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317514#comment-14317514
]
Kai Zheng commented on HADOOP-11542:
------------------------------------
Hi [~zhz] for your good catches. I will update patch to resolve 1 & 2.
bq.Do we need to apply the mask before casting to byte?
I thought it applied the mask before the casting, as necessarily, and we don't
need extra masking in the statement. Please correct me if I'm not getting you.
Thanks.
bq.we can also add a direct test for the added bulk methods
For performance consideration we currently only use the bulk version. For the
single {{int}} level versions, we don't use or haven't got the chance to use
yet. Tests for them are good to have, though.
> Raw Reed-Solomon coder in pure Java
> -----------------------------------
>
> Key: HADOOP-11542
> URL: https://issues.apache.org/jira/browse/HADOOP-11542
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HDFS-EC
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HADOOP-11542-v1.patch, HADOOP-11542-v2.patch,
> HADOOP-11542-v3.patch, HADOOP-11542-v4.patch, HDFS-RAID-GaloisField.java
>
>
> This will implement RS coder by porting existing codes in HDFS-RAID in the
> new codec and coder framework, which could be useful in case native support
> isn't available or convenient in some environments or platforms.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
