[ 
https://issues.apache.org/jira/browse/HADOOP-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310473#comment-14310473
 ] 

Kai Zheng commented on HADOOP-11542:
------------------------------------

Hi [~zhz],

Thanks for your helpful review to move a little bit faster.
bq.I don't think we need to put Java in the class name
I want to distinguish it from native coders. We'll also have ISA one for RS 
code scheme. How about {{JRSRawEncoder}} ? Note as it's in pure Java its 
efficiency is very low so I thought it would be good not to have users think 
it's the default and right good RS implementation. 
bq.I think we should remove "test usage". They'll be used all-around if native 
coders are not available.
OK, agree.
Regarding {{GaloisField}} and related, it's almost the same from HDFS-RAID. I 
did add some functions to support ByteBuffer. As you suggested, I will compare 
and give comments for the updated parts.
Will update the patch when HADOOP-11541 is in.

> Raw Reed-Solomon coder in pure Java
> -----------------------------------
>
>                 Key: HADOOP-11542
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11542
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: HDFS-EC
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HADOOP-11542-v1.patch, HADOOP-11542-v2.patch
>
>
> This will implement RS coder by porting existing codes in HDFS-RAID in the 
> new codec and coder framework, which could be useful in case native support 
> isn't available or convenient in some environments or platforms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to