[ 
https://issues.apache.org/jira/browse/HADOOP-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508398#comment-14508398
 ] 

Akira AJISAKA commented on HADOOP-11821:
----------------------------------------

Thanks [~brahmareddy] for creating a patch.

bq. SE_BAD_FIELD erros want to add in exclude.xml since those are maps but 
fixed ( let me know your thought on this,..)..
I'm +1 for fixing the warning instead of adding a section in 
findbugs-exclude.xml. Following steps can fix the bug.
# Make the maps {{transient}}.
# Add private {{readObject(ObjectInputStream)}} method for deserialization and 
initialize the maps there.
{code}
  private void readObject(ObjectInputStream in) throws IOException,
      ClassNotFoundException {
    in.defaultReadObject();
    handleOperTimecostHistogramMap = new HashMap<>();
    queueAllocatedMemoryCounterMap = new HashMap<>();
    queueAllocatedVCoresCounterMap = new HashMap<>();
  }
{code}

> Fix findbugs warnings in hadoop-sls
> -----------------------------------
>
>                 Key: HADOOP-11821
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11821
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-11821-001.patch, HADOOP-11821.patch
>
>
> Per 
> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5388//artifact/patchprocess/newPatchFindbugsWarningshadoop-sls.html,
>   there are 13 warnings to be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to