[
https://issues.apache.org/jira/browse/HADOOP-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511033#comment-14511033
]
Hadoop QA commented on HADOOP-11821:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 25s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 30s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 5m 31s | The applied patch generated 1
additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 0m 44s | The patch appears to introduce 1
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | tools/hadoop tests | 0m 53s | Tests passed in
hadoop-sls. |
| | | 41m 8s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-sls |
| | Found reliance on default encoding in
org.apache.hadoop.yarn.sls.RumenToSLSConverter.generateSLSNodeFile(String):in
org.apache.hadoop.yarn.sls.RumenToSLSConverter.generateSLSNodeFile(String): new
java.io.FileWriter(String) At RumenToSLSConverter.java:[line 149] |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12727903/HADOOP-11821-003.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 91b97c2 |
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6172/artifact/patchprocess/whitespace.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6172/artifact/patchprocess/checkstyle-result-diff.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6172/artifact/patchprocess/newPatchFindbugsWarningshadoop-sls.html
|
| hadoop-sls test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6172/artifact/patchprocess/testrun_hadoop-sls.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6172/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6172/console |
This message was automatically generated.
> Fix findbugs warnings in hadoop-sls
> -----------------------------------
>
> Key: HADOOP-11821
> URL: https://issues.apache.org/jira/browse/HADOOP-11821
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools
> Reporter: Akira AJISAKA
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-11821-001.patch, HADOOP-11821-002.patch,
> HADOOP-11821-003.patch, HADOOP-11821.patch
>
>
> Per
> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5388//artifact/patchprocess/newPatchFindbugsWarningshadoop-sls.html,
> there are 13 warnings to be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
