[
https://issues.apache.org/jira/browse/HADOOP-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516631#comment-14516631
]
Akira AJISAKA commented on HADOOP-11821:
----------------------------------------
Hi [~brahmareddy], would you fix checkstyle warnings?
{code:title=SLSWebApp}
private transient Map<SchedulerEventType, Histogram>
handleOperTimecostHistogramMap;
{code}
Would you render the line within 80 characters?
{code:title=RumenToSLSConverter#generateSLSLoadFile}
try(Writer output =
new OutputStreamWriter(new FileOutputStream(outputFile), "UTF-8");) {
{code}
* Would you please add a whitespace between 'try' and '(' ?
* The semicolon is unnecessarily.
> Fix findbugs warnings in hadoop-sls
> -----------------------------------
>
> Key: HADOOP-11821
> URL: https://issues.apache.org/jira/browse/HADOOP-11821
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools
> Reporter: Akira AJISAKA
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-11821-001.patch, HADOOP-11821-002.patch,
> HADOOP-11821-003.patch, HADOOP-11821-004.patch, HADOOP-11821.patch
>
>
> Per
> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5388//artifact/patchprocess/newPatchFindbugsWarningshadoop-sls.html,
> there are 13 warnings to be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
