[
https://issues.apache.org/jira/browse/HADOOP-11821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510434#comment-14510434
]
Akira AJISAKA commented on HADOOP-11821:
----------------------------------------
Thanks [~brahmareddy] for the patch. Mostly looks good to me. Two minor nits:
1. Would you remove unused imports from the following classes?
* SLSCapacityScheduler.java
* SLSWebApp.java
2. Would you render the line within 80 characters?
{code}
@@ -277,7 +277,7 @@ private void startAMFromSLSTraces(Resource
containerResource,
JsonFactory jsonF = new JsonFactory();
ObjectMapper mapper = new ObjectMapper();
for (String inputTrace : inputTraces) {
- Reader input = new FileReader(inputTrace);
+ Reader input = new InputStreamReader(new FileInputStream(inputTrace),
"UTF-8");
{code}
> Fix findbugs warnings in hadoop-sls
> -----------------------------------
>
> Key: HADOOP-11821
> URL: https://issues.apache.org/jira/browse/HADOOP-11821
> Project: Hadoop Common
> Issue Type: Bug
> Components: tools
> Reporter: Akira AJISAKA
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-11821-001.patch, HADOOP-11821-002.patch,
> HADOOP-11821.patch
>
>
> Per
> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5388//artifact/patchprocess/newPatchFindbugsWarningshadoop-sls.html,
> there are 13 warnings to be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
