Re: [lang] FastDateFormat Update

[Sean Schofield]

Thanks for the feedback. FastDateFormat doesn't seem to be as thread safe as advertised (at least in the version we are using.) There are a few instances of HashMap (some of which I was already proposing to eliminate b/c they are only being used by the getDateTimeInstance, etc. methods).
I looked at the FastHashMap as a replacement and I have some major misgivings given the dire javadoc warnings and the equally pessimistic article they reference. I don't see a problem with using Hashtable.

- sean

PS. See below for Dick's comments

4) Consider replacing use of HashMap due to the problem that Dick has
mentioned.

Damn. Now you make me have to pay attention to 2 emails at once. No clue
which one was this though.

<snip>

Hi,

I saw your posting for the FastDateFormat class and noticed that you have
removed the synchronization on the getInstance method.
Shouldn't you then protect the call to cInstanceCache.put by doing a clone
of the Hashmap first (similar to the commons collections FastHashMap class)
to make sure that this works correctly in a multi-threaded environment?

Best regards,

Dick Zetterberg

</snip>





--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>