On Tue, 7 Jan 2003, Stephen Colebourne wrote:
> ----- Original Message ----- > From: "Henri Yandell" <[EMAIL PROTECTED]> > > On Tue, 7 Jan 2003, Sean Schofield wrote: > > > 1) I removed two of the overloaded getInstance() methods that took > > > DateFormatSymbols as arguments. SimpleDateFormat does allow a > > > DateFormat to be constructed using DateFormatSymbols but I thought for > > > now it might be nice to leave this out. It could be argued, however, > > > that we should include support for this, since some have described this > > > class as a thread-safe replacement for SimpleDateformat. (Actually the > > > changes related to this were commented-out for now so we can undo them > > > if people want.) > > > > If there's no reason as to why they're a pain to keep in, would be nice to > > not get some javadoc-lawyer hitting us with the reason why FastDateFormat > > isn't a SimpleDateFormat replacement. > > Its not a SimpleDateFormat drop-in as it doesn't extend Format. It should do > (not the parsing, just the formatting part - throw > UnsupportedOperationException from the parsing) Yup. Definitely _has_ to extend Format. Even if it isn't seen as a SimpleDateFormat option. > > > 2) Removed 'throws IllegalArgumentException' from several methods. IMO, > > > runtime exceptions should not be declared in the method. I checked > > > several other classes in commons-lang and it seems that this follows the > > > current commons-lang coding convention as well. > > > > I think this is quite debatable and up-in-the-air. You're not shattering > > any rules by not having them in there, but there's a definite school of > > thought in favour of them being there. > > I oppose putting runtime exceptions in the throws clause, and so support > their removal. Probably should change developers-guide. Ack. I mis-read. I thought he removed the IAE's themselves and not just the declaration :) +1 on developers-guide mention. Hen -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
