https://bugs.contribs.org/show_bug.cgi?id=10091
--- Comment #2 from Jean-Philippe Pialasse <[email protected]> ---
seems we are using the whitelist_soft that has not been upgraded with karma
support, while the whitelist is almost the same except the name and karma
support.
# rpm -qf whitelist
qpsmtpd-0.96-8.el6.sme.noarch
# rpm -qf whitelist_soft
qpsmtpd-plugins-0.0.1-4.el6.sme.noarch
# rpm -qf
/etc/e-smith/templates/var/service/qpsmtpd/config/peers/0/11whitelist_soft
smeserver-wbl-0.3.0-12.el6.sme.noarch
so I first suggest to switch from whitelist_soft to whitelist in the contribs
then the problem we see, we have 3 whitelists related to the plugin:
whitelisthelo
whitelisthosts
whitelistsenders
a new perl module defining is_immune (called to check for whitelist in most
plugins)check for :
- ($self->qp->connection->notes('whitelisthost')) # set by
plugins/dns_whitelist_soft or plugins/whitelist
- ($self->qp->connection->relay_client()) # set by plugins/relay, or
Qpsmtpd::Auth
- ($self->qp->transaction->notes('whitelistsender')) # set by
plugins/whitelist
whitelistsenders seems simply ignored
whitelisthelo seems also simply ignored
whitelisthosts is expected to works with IP
I will do more test with the new whitelist plugin, but I see one cave-heat yet
:
- only two plugins have the is_immune tag at mail stage ( rhsbl,
sender_permitted) while karma, earlytalker resolvable_fromhost (alternative
system exist), naughty and badmailfrom do not have
- for the rcpt phase naughty and badmailfrom might miss indeed a is_immune()
- whitelisthelo still needs a hook somewhere
by the way whitelistrcpt has not yet been used
also to note : the manager indicate that whitelistsenders is used at mail
stage, but it is also at rcpt, idem for helo and host they are used "since" X
phase
so what I plan to do :
1-change to whitelist plugin
2- patch lib/Qpsmtpd/Plugin.pm is_immune to add the other whitelist not already
used...
-- whitelisthelo (will not be done upstream :
https://github.com/smtpd/qpsmtpd/issues/226) alternatively we could drop the
helo whitelisting.
-- whitelistsenders
3- see what happen , then check if we really need to :
4- patch karma, earlytalker resolvable_fromhost (alternative system exist),
naughty and badmailfrom with a is_immune() in rcpt and mail stages. only if
previous step was not enough
see https://github.com/smtpd/qpsmtpd/issues/203
--
You are receiving this mail because:
You are the QA Contact for the bug._______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/
