https://bugs.contribs.org/show_bug.cgi?id=10091
Daniel B. <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[email protected]
| |m
--- Comment #5 from Daniel B. <[email protected]> ---
(In reply to Jean-Philippe Pialasse from comment #2)
> so what I plan to do :
> 1-change to whitelist plugin
Makes sens if they are almost the same, as whitelist is the upstream one.
>
> 2- patch lib/Qpsmtpd/Plugin.pm is_immune to add the other whitelist not
> already used...
> -- whitelisthelo (will not be done upstream :
> https://github.com/smtpd/qpsmtpd/issues/226) alternatively we could drop the
> helo whitelisting.
I'd be in favor of not adding this. Is anyone really using helo whitelisting ?
> -- whitelistsenders
I don't undserstand. The existing is_immune function already checks for the
whitelistsender transaction note, which should be added by the whitelist
plugin. If this is not working, it must be investigated, but I see no reason to
patch qpsmtpd yet.
>
> 3- see what happen , then check if we really need to :
> 4- patch karma, earlytalker resolvable_fromhost (alternative system exist),
> naughty and badmailfrom with a is_immune() in rcpt and mail stages. only if
> previous step was not enough
karma already checks is_immune in connect and data stages.
earlytalker already checks is_immune in connect and data stages too.
resolvable_fromhost already checks is_immune at the mail stage (the only stage
hooked)
naughty is not checking is_immune. But this is because naughty is particular.
It's not doing any check by itself, it's just a helper to defer rejection at a
later stage. All the plugins which are setting the naughty transaction note
already honor is_immune I think, so it shouldn't be a problem
badmailfrom already checks is_immune at the mail stage (the only stage hooked)
So, to me, it looks like this bug is only about:
- Sender whitelisting not working, for some reason. We need to investigate as
from a quick look at the code, it should be supported
- Helo whitelisting not working. I'm not sure if we really need this. It's
potentialy dangerous, as very easy to impersonate. If someone uses helo
whitelisting, please manifest yourself to prove I'm wrong ;-)
--
You are receiving this mail because:
You are the QA Contact for the bug._______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/
