https://bugs.contribs.org/show_bug.cgi?id=10091
--- Comment #10 from Jean-Philippe Pialasse <[email protected]> ---
(In reply to Daniel B. from comment #8)
> (In reply to Jean-Philippe Pialasse from comment #6)
> > > > helo whitelisting.
> > >
> > > I'd be in favor of not adding this. Is anyone really using helo
> > > whitelisting
> > > ?
> > we had this integrated in former dns plugin with a patch.
> > John is, at least, using it, and I
>
>
> Ok. It seems a bit dangerous to me to use it, but it's a trivial patch in
> qpsmtpd (just check the whitelisthelo transaction note in is_immune), and as
> long as the defaut conf is empty, it won't have any effect, so, OK for this
> part.
ok so no ore to say there.
> > > karma already checks is_immune in connect and data stages.
> > but not at rcpt and mail stage see my calc sheet
>
> But, as karma doesn't hook at the rcpt stage, it doesn't need to check for
> immunity ;-)
but it is hooked in mail and does not check for immune
>
> > >
> > > earlytalker already checks is_immune in connect and data stages too.
> >
> > but not at mail stage !this means that if it was not immune at the first
> > step, it will have put a tag and will log and deny the mail even if the
> > sender is whitelisted (at connect helo sender is not available, at data this
> > is too late) !!
>
>
> Ok, I understand the issue now. We can add an immunity check in earlytalker
> at the mail stage (even if I doubt it'll be used, earlytalker should really
> only triggers on real spammers)
ok, will try , but still, I will first start with keeping the feature of helo
for who wants to live with it.
>
>
> > >
> > > So, to me, it looks like this bug is only about:
> > >
> > > - Sender whitelisting not working, for some reason. We need to investigate
> > > as from a quick look at the code, it should be supported
> >
> > it is not working because mail is reject before getting there.
>
>
> Ok, after reading again your log, I get it. The problem exists because we
> use the naughty plugin. The easiest fix is to check for immunity in the
> naughty plugin, so, a simple
>
> return DECLINED if $self->is_immune;
>
> in /usr/share/qpsmtpd/plugins/naughty in the naughty function should fix it.
well i would say no as :
- you told that naughty should not get the immune
- again if you only rely on sender whitelist this arrives only at mail stage,
too late
but i will test
--
You are receiving this mail because:
You are the QA Contact for the bug.
_______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/
