On 06/12/2013 10:41 AM, Paul Sandoz wrote:
Looks ok to me in my unofficial reviewer role.
Paul.
like Paul, not an official reviewer;
The patch looks good, nice to see that String is on diet.
just nitpicking, in HashMap/HashTable readObject, there is no
parenthesis in front of the '?',
0 != seed? seed: 1
should be
(0 != seed)? seed: 1
cheers,
Rémi
On Jun 11, 2013, at 10:32 PM, Brent Christian <brent.christ...@oracle.com>
wrote:
Hi,
Please review my fix for 8010325. Some background:
The alternative string-hashing implementation[1] added to java.lang.String a
new public method, hash32(), as well as a new private int field to cache the
alternate hash value.
Following 8005698 [2] and 8005704 [3], the new method and field in String are
no longer used.
By updating a couple lines in Hashtable/HashMap/WeakHashMap, the internal
sun.misc.Hashing class can also be removed.
The webrev is here:
http://cr.openjdk.java.net/~bchristi/8010325/webrev.00/
Thanks,
-Brent
1. http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/43bd5ee0205e
2. http://bugs.sun.com/view_bug.do?bug_id=8005698
3. http://bugs.sun.com/view_bug.do?bug_id=8005704
