On 6/12/13 7:55 PM, David Holmes wrote:
Something of an aside but ...

On 13/06/2013 3:45 AM, Martin Buchholz wrote:
Hi Brent,

Thanks for doing this.

Your webrev does not include mercurial changeset information, which I
think
is supported by recent webrevs.

Given the changeset has to be created after the review is complete
most/many people will not have a changeset prepared at review time.

That's it exactly. If at all possible, I don't commit until the code has completed code review. I tell webrev to do its thing based on modified files, rather than outgoing changesets.

-Brent

Reply via email to