Something of an aside but ...
On 13/06/2013 3:45 AM, Martin Buchholz wrote:
Hi Brent,
Thanks for doing this.
Your webrev does not include mercurial changeset information, which I think
is supported by recent webrevs.
Given the changeset has to be created after the review is complete
most/many people will not have a changeset prepared at review time. The
webrev support for changesets IIRC was for a specific group of people
with a specific working style (using mq) that was much more convenient
when webrevs had changesets rather than just patches.
David
-----
I assume you've been working with Doug Lea on this. If not, the two of you
should talk.
BTW, it's sad not to see things like murmur hash be public supported
algorithms - but I think guava provides it.
On Tue, Jun 11, 2013 at 1:32 PM, Brent Christian <brent.christ...@oracle.com
wrote:
Hi,
Please review my fix for 8010325. Some background:
The alternative string-hashing implementation[1] added to java.lang.String
a new public method, hash32(), as well as a new private int field to cache
the alternate hash value.
Following 8005698 [2] and 8005704 [3], the new method and field in String
are no longer used.
By updating a couple lines in Hashtable/HashMap/WeakHashMap, the internal
sun.misc.Hashing class can also be removed.
The webrev is here:
http://cr.openjdk.java.net/~**bchristi/8010325/webrev.00/<http://cr.openjdk.java.net/~bchristi/8010325/webrev.00/>
Thanks,
-Brent
1.
http://hg.openjdk.java.net/**jdk8/jdk8/jdk/rev/43bd5ee0205e<http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/43bd5ee0205e>
2.
http://bugs.sun.com/view_bug.**do?bug_id=8005698<http://bugs.sun.com/view_bug.do?bug_id=8005698>
3.
http://bugs.sun.com/view_bug.**do?bug_id=8005704<http://bugs.sun.com/view_bug.do?bug_id=8005704>
