Hi Sherman,
My apology for the belated review. I just return from vacation.
On 11/20/17 6:58 PM, Xueming Shen wrote:
http://cr.openjdk.java.net/~sherman/8189611/webrev
Just passing comments.
140 * that {@link getName()} returns. should be #getName(). There are a
couple other @link missing #.
src/java.base/share/classes/module-info.java
line 214: the semi-colon is missing. It didn't fail the
compilation because gensrc/java.base/module-info.java is generated to
append the OS-specific module declaration and the build tool appends the
semi-colon. The build tool should catch this.
jdeps' VersionHelper.java still accesses the "getRealName()" via the
SharedSecrets.
Since jdeps is being compiled/built with the bootjdk, I'm leaving it
untouched for
now.
I have filed JDK-8191942 for this. jdeps is not needed as the interim
module (which runs on the boot JDK runtime). CreateSymbols depends on
com.sun.tools.classfile library that is in jdk.jdeps module. We can
modify the build to include com.sun.tools.classfile in the create symbol
build tool classes to avoid compiling jdk.jdeps interim module.
I will start a review thread for JDK-8191942 that I can push soon after
you push this fix.
Mandy
