> On 20 Nov 2017, at 18:58, Xueming Shen <xueming.s...@oracle.com> wrote:
> 
> Thanks Paul!
> 
> Webrev has been updated as suggested.
> 
> http://cr.openjdk.java.net/~sherman/8189611/webrev
> 
> jdeps' VersionHelper.java still accesses the "getRealName()" via the 
> SharedSecrets.
> Since jdeps is being compiled/built with the bootjdk, I'm leaving it 
> untouched for
> now.
> 
> ----------------------
> 610 // placeholder for now
> 611 String getRealName(JarEntry entry) {
> 612 return entry.getRealName();
> 613 } No longer required?
> 
> I dunno what calls it...
> —————————————
> 

Ok, I suggest adding a comment as to why it is still needed. No need for 
another review round.

Thanks,
Paul.

Reply via email to