On 11/27/17, 5:43 PM, mandy chung wrote:
On 11/20/17 6:58 PM, Xueming Shen wrote:
http://cr.openjdk.java.net/~sherman/8189611/webrev
Just passing comments.
140 * that {@link getName()} returns.
should be #getName(). There are a couple other @link missing #.
src/java.base/share/classes/module-info.java
line 214: the semi-colon is missing. It didn't fail the
compilation because gensrc/java.base/module-info.java is generated to
append the OS-specific module declaration and the build tool appends
the semi-colon. The build tool should catch this.
Thanks Mandy!
webrev has been updated accordingly as suggested. now wait for the csr.
-Sherman
