Hi Christoph, This is a big change, and it seems a lot more changed than resolving Hunks. Some hunks are missing altogether.
For example, http://hg.openjdk.java.net/jdk/jdk/rev/ba51515b64e5, ZipFileSystem 2341 2.341- IndexNode inode = new IndexNode(cen, nlen, pos); 2.342+ IndexNode inode = new IndexNode(cen, pos, nlen); Is missing in your change. And I see much more differences if I compare the diffs. Please explain. Best regards, Goetz. > -----Original Message----- > From: core-libs-dev <core-libs-dev-boun...@openjdk.java.net> On Behalf > Of Langer, Christoph > Sent: Thursday, January 24, 2019 5:41 PM > To: core-libs-dev@openjdk.java.net > Subject: [CAUTION] RFR [11u backport]: 8034802: (zipfs) newFileSystem > throws UOE when the zip file is located in a custom file system > > Hello, > > please help review this backport for 8034802 to jdk11u: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8034802 > Original Commit: http://hg.openjdk.java.net/jdk/jdk/rev/ba51515b64e5 > Original review thread: https://mail.openjdk.java.net/pipermail/core-libs- > dev/2018-September/055490.html > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8034802.11u/ > > The patch did not apply cleanly - I had to manually resolve 3 hunks. Jtreg > tests > for zipfs all pass. > > Thanks > Christoph
