On Thu, 10 Dec 2020 09:36:44 GMT, Andrew Haley <[email protected]> wrote:
>> Nick Gasson has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 3192:
>
>> 3190: spills += RegSet::of(output->as_Register());
>> 3191: } else if (output->is_FloatRegister()) {
>> 3192: fp_spills += RegSet::of((Register)output->as_FloatRegister());
>
> This looks very strange. Does it generate the correct code for FloatRegisters?
Er... no. But not because of the cast. The `push(fp_spills)` below should be
`push_fp(fp_spills)`. I'll add a FloatRegister constructor to RegSet so it
doesn't need that any more. There's one other place that does it in
cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.cpp
-------------
PR: https://git.openjdk.java.net/jdk/pull/1711
