On Thu, 10 Dec 2020 10:25:33 GMT, Nick Gasson <[email protected]> wrote:
>> push_fp() doesn't make much sense if the RegSet is a set of Registers, which >> are by definition not FloatRegisters. That casting of Register to >> FloatRegister in gc/z is evil. > > Should we have a separate RegSet type for FloatRegisters to avoid mixing them > up? Absolutely. I'd make an AbstractRegSet and use it as a base type for both RegSet and FloatRegSet, then we can get rid of the casts altogether. ------------- PR: https://git.openjdk.java.net/jdk/pull/1711
