On Thu, 10 Dec 2020 10:21:09 GMT, Andrew Haley <[email protected]> wrote:
>> Er... no. But not because of the cast. The `push(fp_spills)` below should be >> `push_fp(fp_spills)`. I'll add a FloatRegister constructor to RegSet so it >> doesn't need that any more. There's one other place that does it in >> cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.cpp > > push_fp() doesn't make much sense if the RegSet is a set of Registers, which > are by definition not FloatRegisters. That casting of Register to > FloatRegister in gc/z is evil. Should we have a separate RegSet type for FloatRegisters to avoid mixing them up? ------------- PR: https://git.openjdk.java.net/jdk/pull/1711
